Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add search feature to webmvc-http sample #211

Closed

Conversation

jvalkeal
Copy link
Contributor

@jvalkeal jvalkeal commented Dec 5, 2021

Thought I'd create this PR if you find it useful as I wanted to see what comes out with union types as no samples uses it.

  • This is not to add any kind of sophisticated search feature but to
    have unions in a query result to see what comes out with example like:
    query {
      search(text: "spring", type: ARTIFACTREPOSITORY) {
        ... on ArtifactRepository {
          name
        }
        ... on Project {
          name
        }
      }
    }

where you can use text as search field for names and optionally use type
to limit results either to ARTIFACTREPOSITORY or PROJECT.

- This is not to add any kind of sophisticated search feature but to
  have unions in a query result to see what comes out with example like:

    query {
      search(text: "spring", type: ARTIFACTREPOSITORY) {
        ... on ArtifactRepository {
          name
        }
        ... on Project {
          name
        }
      }
    }

  where you can use `text` as search field for names and optionally use `type`
  to limit results either to `ARTIFACTREPOSITORY` or `PROJECT`.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Dec 5, 2021
@rstoyanchev
Copy link
Contributor

rstoyanchev commented Dec 9, 2021

As the Boot starter is about to move (see #207), the samples need to be resettled (see #208). Some will become integration tests within Spring GraphQL (without Boot), we'll be adding getting started guides on spring.io, and perhaps have one more involved sample. So we'll keep this on hold for now.

@rstoyanchev rstoyanchev added the status: blocked An issue that's blocked on an external project change label Dec 9, 2021
@jvalkeal
Copy link
Contributor Author

jvalkeal commented Dec 9, 2021

Yeah, I didn't see those issues until later. Makes sense.

@rstoyanchev rstoyanchev mentioned this pull request Nov 3, 2022
@rstoyanchev
Copy link
Contributor

We'll consider this as part of #208, although I'm not sure there is much, related to unions, that's specific to Spring for GraphQL.

@rstoyanchev rstoyanchev closed this Nov 3, 2022
@rstoyanchev rstoyanchev added status: superseded Issue is superseded by another and removed status: waiting-for-triage An issue we've not yet triaged status: blocked An issue that's blocked on an external project change labels Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: superseded Issue is superseded by another
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants